Repository navigation
Notebook: fold unchanged rows on reopen (PR 17b-2) - #248
Merged
Merged
Conversation
On a reopened experiment, a row whose folders are found exactly as saved and whose question is answered folds behind one line with an open toggle (pairing, names, image types, tag blocks, Check and save replicates). New or changed rows stay open and are marked orange. Display only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G3qp9AxjpGPw9xfWAUJNqc
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G3qp9AxjpGPw9xfWAUJNqc
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G3qp9AxjpGPw9xfWAUJNqc
- reopen_units ignored the reconciliation's reasons, so a folder whose header channel names no longer fit the saved channels (channels_changed), or a renamed folder, folded as "unchanged". Such a unit is now "changed" and stays open, in orange. - An image-type row folded once answered, hiding the warning under its choice (a type the header contradicts, which the run refuses) and an unusable folder's note; it now folds only when answered, usable and with no warning (ImageTypeColumn.note is public for this). - A Check-and-save replicate block folded with its orange A_SCOPE_INCOMPLETE line; a block with a missing label now stays open. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G3qp9AxjpGPw9xfWAUJNqc
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G3qp9AxjpGPw9xfWAUJNqc
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G3qp9AxjpGPw9xfWAUJNqc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the second half of PR 17b, item 1 of the owner's 17b scope ("fold unchanged rows on reopen", already decided in
docs/restart/designs/ux-proposal-2026-11-09.md). It is stacked on #247 (17b-1) and its base isclaude/notebook-17b, so the diff is only 17b-2. Merge #247 first; GitHub then retargets this PR to main.Summary
notebook_row_fold(new,ui):reopen_units(reconciliation)gives the status of each unit against the saved file. A unit isunchangedwhen it is found as saved,changedwhen its member's image count changed, andnewwhen the file does not have it. Units are matched by their exact folder labels (the existingreconcile).row_status(units, keys, answered)says what a row does: it folds only when every unit it holds is unchanged and its question is answered. A row with a new or unknown unit counts as new. Without a saved file nothing folds.RowFoldputs the folded rows behind one line ("✓ 3 unchanged folders, answered as saved") with an open/close toggle, which stays open across rebuilds. New and changed rows stay open, in their order, with an orange border and the chip "new since saved" or "changed since saved".PreprocessingNotebook._reopen_unitsinnotebook_described):Notes for review
embed_minimal_htmlin Playwright chromium (1180 px, deviceScaleFactor 2).Tests
tests/test_notebook_row_fold.py(4 tests):drug/rep2added) folds the unchanged tag block, the 3 image types, thectrlcondition,rep1and its replicate block, and marks the new ones;python tools/check.pyon the head commit (Python 3.13,.[dev,notebook,zarr]): ruff, format and code rules pass; 4975 passed, 4 skipped. These are the same environment skips as Notebook: tags per header block, colour pictures, one-click axes (PR 17b-1) #247: a case-sensitive file system ×3, and running as root, which ignores file modes, ×1.ctrl/rep3anddrug/rep3added. They show Conditions, Replicates (pairing and names), Image type, Tag channels (folded, then opened) and Check and save. Each one was looked at; the fold line's plural ("1 unchanged folder block") was fixed after looking.🤖 Generated with Claude Code
https://claude.ai/code/session_01G3qp9AxjpGPw9xfWAUJNqc